ip6addr_aton allows invalid IPv6 address strings #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two test cases, both of which produce a
true
(valid IP address) response by aton(). Expected result isfalse
(invalid IP address).I'm not sure why, but ip6addr_aton will check for invalid characters and then continue on. My solution was to add a
return 0
in these cases, but I'm not sure if this is a robust solution or will cause more problems. All tests pass with this solution.Update, also found the following failing test case and fixed it:
Update, found more problems, added tests and fixed.