Rust 1.83.0 #1581
Rust 1.83.0 #1581
Conversation
| let base = base | ||
| .clone() | ||
| .or_else(|| Base::from_source(&input_content.source)); | ||
| let base_fallback = Base::from_source(&input_content.source); |
There was a problem hiding this comment.
@mre This is the only change I'm unsure about. Not really happy with this. Creating the base_fallback even when we don't need it is quite ugly. But I couldn't get it to work with inlining it or moving it into the or_else closure, because of lifetime issues. Do you have another idea?
There was a problem hiding this comment.
I agree. We can always disable the lint and add a comment.
|
@mre One additional question - just stumbled upon the test I see that the test is older than the fixture file. So maybe the test started to fail because the fixture was changed without updating the test? |
Yes, we can remove it. If the fixture is easy to be updated, we can also do that, but let's not sweat it. 😉 |
Yes. We're currently blocked on one more review. From my side, it looks fine. @thomas-zahner, could you take a look and try it out on your end? |
|
@trask oh didn't know. Thanks for the info |
|
@thomas-zahner, #1576 got merged, so I guess you can rebase on top of |
|
There are no more meaningful changes in this PR, all changes and clippy suggestions were already applied in #1576 |
Address clippy warnings / errors when using Rust 1.83