Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unmodified core files from web-installer #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhoerr
Copy link
Contributor

@rhoerr rhoerr commented Nov 21, 2024

A lot of the module files appear in core (https://github.com/mage-os/mageos-magento2/tree/2.4-develop/setup) with no differences or only minor differences (with core seeming newer than the versions here). I ran a diff between the core setup folder and this and stripped out almost all of them.

Hopefully this isn't a problem for development of this module. It seems best to avoid code duplication though, and code that does exist in core may have important changes (security or otherwise) from upstream.

@jakwinkler
Copy link
Collaborator

Will have to review that one, Setup module contains fixtures to generated via CLI so not sure if all these files should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants