chore: remove unmodified core files from web-installer #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the module files appear in core (https://github.com/mage-os/mageos-magento2/tree/2.4-develop/setup) with no differences or only minor differences (with core seeming newer than the versions here). I ran a diff between the core setup folder and this and stripped out almost all of them.
Hopefully this isn't a problem for development of this module. It seems best to avoid code duplication though, and code that does exist in core may have important changes (security or otherwise) from upstream.