Bugfix/loader missing effects (#75)

* Bugfix on missing message effects property on failure hook --------- Co-authored-by: Willem <git@wpoortman.nl>
magewirephp · Feb 12, 2023 · ea311d2 · ea311d2
1 parent 988cbec
commit ea311d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/view/frontend/templates/html/loader.phtml b/src/view/frontend/templates/html/loader.phtml
@@ -63,11 +63,11 @@ $magewireScripts = $block->getViewModel();
      x-cloak
      role="status"
      aria-live="polite"
+     x-bind:class="{'z-50 relative': active}"
 >
      <div class="fixed
                  top-0 left-0 right-0 bottom-0
                  w-full h-screen
-                 z-40
                  overflow-hidden
                  bg-white bg-opacity-90"
           x-show="active"

diff --git a/src/view/frontend/templates/page/js/magewire/plugin/loader.phtml b/src/view/frontend/templates/page/js/magewire/plugin/loader.phtml
@@ -75,15 +75,10 @@ use Magewirephp\Magewire\Model\Action\FireEvent;
             start = null,
 
             tryToStop = function(message, component, failed = false) {
-                queue = queue.filter(item => component.id !== item.component.id)
-                let emits = null
+                queue = queue.filter(item => component.id !== item.component.id);
 
-                if (message.response.effects.emits) {
-                    emits = message.response.effects.emits || null
-                }
-
-                if (emits) {
-                    emits.forEach((emit) => {
+                if (message.response && message.response.effects) {
+                    (message.response.effects.emits || []).forEach((emit) => {
                         Magewire.components.componentsListeningForEvent(emit.event).forEach((component) => {
                             queue.push({ component: component, emit: true })
                         })