Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RD-459_reimplement-handling-webgl-context-loss #146

Open
wants to merge 4 commits into
base: v3.0.0
Choose a base branch
from

Conversation

sebstryczek
Copy link

Objective

What is the goal?

Description

What changed, how and why?

Acceptance

How were changes tested?

Checklist

  • I have added relevant info to the CHANGELOG.md

@sebstryczek sebstryczek marked this pull request as ready for review December 19, 2024 11:02
@sebstryczek sebstryczek requested review from petrsloup and removed request for jonathanlurie December 19, 2024 17:02
@sebstryczek sebstryczek changed the base branch from main to v3.0.0 December 19, 2024 17:12
@petrsloup
Copy link
Member

This PR now contains a bunch of unrelated changes because it's based on newer main than v3.0.0. Maybe rebasing v3.0.0/merging main into v3.0.0 first would make this cleaner.. ?

Copy link
Member

@petrsloup petrsloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add note to the changelog (as part of every PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants