code review feedback

masseyke · Nov 15, 2023 · 0099cfa · 0099cfa
1 parent 822b6c6
commit 0099cfa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
@@ -366,7 +366,7 @@ protected void doInternalExecute(Task task, BulkRequest bulkRequest, String exec
         }
 
         // Step 3: create all the indices that are missing, if there are any missing. start the bulk after all the creates come back.
-        createMissingIndicesAndindexData(
+        createMissingIndicesAndIndexData(
             task,
             bulkRequest,
             executorName,
@@ -380,7 +380,7 @@ protected void doInternalExecute(Task task, BulkRequest bulkRequest, String exec
     /*
      * This method is responsible for creating any missing indices and indexing the data in the BulkRequest
      */
-    protected void createMissingIndicesAndindexData(
+    protected void createMissingIndicesAndIndexData(
         Task task,
         BulkRequest bulkRequest,
         String executorName,

diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportSimulateBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportSimulateBulkAction.java
@@ -64,7 +64,7 @@ public TransportSimulateBulkAction(
      * request gets a corresponding CREATE response, using information from the request.
      */
     @Override
-    protected void createMissingIndicesAndindexData(
+    protected void createMissingIndicesAndIndexData(
         Task task,
         BulkRequest bulkRequest,
         String executorName,

diff --git a/server/src/main/java/org/elasticsearch/rest/action/ingest/RestSimulateIngestAction.java b/server/src/main/java/org/elasticsearch/rest/action/ingest/RestSimulateIngestAction.java
@@ -16,7 +16,6 @@
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.xcontent.XContentHelper;
-import org.elasticsearch.core.RestApiVersion;
 import org.elasticsearch.core.Tuple;
 import org.elasticsearch.ingest.ConfigurationUtils;
 import org.elasticsearch.ingest.IngestDocument;
@@ -69,9 +68,6 @@ public String getName() {
     @Override
     @SuppressWarnings("unchecked")
     public RestChannelConsumer prepareRequest(final RestRequest request, final NodeClient client) throws IOException {
-        if (request.getRestApiVersion() == RestApiVersion.V_7 && request.hasParam("type")) {
-            request.param("type");
-        }
         String defaultIndex = request.param("index");
         FetchSourceContext defaultFetchSourceContext = FetchSourceContext.parseFromRestRequest(request);
         String defaultPipeline = request.param("pipeline");

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportSimulateBulkActionTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportSimulateBulkActionTests.java
@@ -192,7 +192,7 @@ public void onFailure(Exception e) {
         Set<String> autoCreateIndices = Set.of(); // unused
         Map<String, IndexNotFoundException> indicesThatCannotBeCreated = Map.of(); // unused
         long startTime = 0;
-        bulkAction.createMissingIndicesAndindexData(
+        bulkAction.createMissingIndicesAndIndexData(
             task,
             bulkRequest,
             randomAlphaOfLength(10),