fixing RestIndexAction

masseyke · Jan 2, 2024 · a270429 · a270429
1 parent 097312f
commit a270429
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/rest/action/document/RestIndexAction.java b/server/src/main/java/org/elasticsearch/rest/action/document/RestIndexAction.java
@@ -8,6 +8,7 @@
 
 package org.elasticsearch.rest.action.document;
 
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.action.DocWriteRequest;
 import org.elasticsearch.action.DocWriteResponse;
 import org.elasticsearch.action.index.IndexRequest;
@@ -145,10 +146,14 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC
 
             return channel -> client.index(
                 indexRequest,
-                new RestToXContentListener<>(channel, DocWriteResponse::status, r -> r.getLocation(indexRequest.routing()))
+                ActionListener.runAfter(
+                    new RestToXContentListener<>(channel, DocWriteResponse::status, r -> r.getLocation(indexRequest.routing())),
+                    indexRequest::decRef
+                )
             );
-        } finally {
+        } catch (Exception e) {
             indexRequest.decRef();
+            throw e;
         }
     }