trying to determine when a primary resource error should be plural or…

… not.
mattpolzin · Aug 24, 2022 · aec39fc · aec39fc
1 parent 9e8c288
commit aec39fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Sources/JSONAPI/Document/DocumentDecodingError.swift b/Sources/JSONAPI/Document/DocumentDecodingError.swift
@@ -33,7 +33,7 @@ public enum DocumentDecodingError: Swift.Error, Equatable {
             self = .primaryResourceMissing
         case .valueNotFound(let type, let context) where Location(context) == .data && type == UnkeyedDecodingContainer.self:
             self = .primaryResourcesMissing
-        case .typeMismatch(let type, let context) where Location(context) == .data && type == UnkeyedDecodingContainer.self && context.debugDescription.hasSuffix("but found null instead."):
+        case .typeMismatch(let type, let context) where Location(context) == .data && type is _ArrayType.Type && context.debugDescription.hasSuffix("but found null instead."):
             self = .primaryResourcesMissing
         case .typeMismatch(_, let context) where Location(context) == .data && context.debugDescription.hasSuffix("but found null instead."):
             self = .primaryResourceMissing
@@ -75,3 +75,6 @@ extension DocumentDecodingError: CustomStringConvertible {
         }
     }
 }
+
+private protocol _ArrayType {}
+extension Array: _ArrayType {}
diff --git a/Tests/JSONAPITests/Document/DocumentDecodingErrorTests.swift b/Tests/JSONAPITests/Document/DocumentDecodingErrorTests.swift
@@ -53,7 +53,7 @@ final class DocumentDecodingErrorTests: XCTestCase {
         ) { error in
             guard let docError = error as? DocumentDecodingError,
                 case .primaryResourcesMissing = docError else {
-                    XCTFail("Expected primary resource missing error. Got \(error)")
+                    XCTFail("Expected primary resources missing error. Got \(error)")
                     return
             }