Added sorting to secret list #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The concern I see with this is that the order it shows up in the sidebar is also the order that it presents them via the agent -- e.g. if you have more than one secret that is valid for a connection it will use them in the order presented. Most of the time that probably isn't an issue, but if there was a way to manually change the order of secrets from a PIV usb key then this would be a big deal for me =] I think the correct fix is to allow either manual or by name sorting, but it needs to sort them in the backend whatever that is, not just in the display -- because the order they are in does actually mean something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sorting by secret name to secrets list sidebar.