bugfix: dialog will be shown on top (#290)

* bugfix: dialog will be shown on top * bugfix: dialog will be shown on top * fix tests (issue #275) Co-authored-by: Maxime Lafarie <5319267+maximelafarie@users.noreply.github.com>
maximelafarie · Oct 14, 2021 · cc87c69 · cc87c69
1 parent d92cd42
commit cc87c69
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/ngx-smart-modal/src/services/ngx-smart-modal.service.ts b/src/ngx-smart-modal/src/services/ngx-smart-modal.service.ts
@@ -280,11 +280,11 @@ export class NgxSmartModalService {
     }) as EventListener);
 
     window.addEventListener(NgxSmartModalConfig.prefixEvent + 'open', ((e: CustomEvent) => {
-      this._openModal(e.detail.instance.modal, e.detail.top);
+      this._openModal(e.detail.instance.modal, e.detail.extraData.top);
     }) as EventListener);
 
     window.addEventListener(NgxSmartModalConfig.prefixEvent + 'toggle', ((e: CustomEvent) => {
-      this._toggleModal(e.detail.instance.modal, e.detail.top);
+      this._toggleModal(e.detail.instance.modal, e.detail.extraData.top);
     }) as EventListener);
 
     window.addEventListener(NgxSmartModalConfig.prefixEvent + 'close', ((e: CustomEvent) => {

diff --git a/src/ngx-smart-modal/tests/services/ngx-smart-modal.service.spec.ts b/src/ngx-smart-modal/tests/services/ngx-smart-modal.service.spec.ts
@@ -66,7 +66,9 @@ describe('NgxSmartModalService', () => {
         instance: {
           modal: 'fake modal'
         },
-        top: true
+        extraData: {
+          top: true
+        }
       }
     };