Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog is not always shown on top of another dialog #275

Open
be-ndee opened this issue Mar 9, 2020 · 4 comments
Open

Dialog is not always shown on top of another dialog #275

be-ndee opened this issue Mar 9, 2020 · 4 comments
Assignees

Comments

@be-ndee
Copy link
Contributor

be-ndee commented Mar 9, 2020

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I have two dialogs. Dialog A and dialog B. I call dialogA.open(true) in dialog A. Then I close dialog A with dialogA.close(). Then I open dialog B with dialogB.open(true). When dialog B is opened, I open dialog A aswell with dialogA.open(true). Dialog A will then be shown behind dialog B.

Expected behavior
Dialog A should be shown on top dialog B, not behind it.

Reproduction of the problem Important is, that the dialog, which should be shown on top of another dialog, must have been opened and closed before the dialog underneath it. So you have to open and close dialog A, then open dialog B and open dialog A.

What is the motivation / use case for changing the behavior? It's a bug :-D

Please tell us about your environment:

  • Smart Modal version: 7.3.0

  • Angular version: 8.2.14

  • Browser: all

  • Language: all

@be-ndee
Copy link
Contributor Author

be-ndee commented Mar 9, 2020

I already created a pull request, because I found the bug: #274

@maximelafarie
Copy link
Owner

Hi @be-ndee! Sorry for the late answer. Thank you very much for your PR, can you just please create a new one with your code rebased on the master branch? Since we updated our PR-check rules, previous PRs seem a bit messy. I'll merge it as soon as you created the new one. (I'll close the #274 after that). 🖖

@maximelafarie maximelafarie self-assigned this Jun 19, 2020
@maximelafarie maximelafarie linked a pull request Jun 19, 2020 that will close this issue
@be-ndee
Copy link
Contributor Author

be-ndee commented Jun 22, 2020

Thank you, I've created a new PR #290

be-ndee added a commit to be-ndee/ngx-smart-modal that referenced this issue Oct 15, 2020
maximelafarie added a commit that referenced this issue Oct 14, 2021
* bugfix: dialog will be shown on top

* bugfix: dialog will be shown on top

* fix tests (issue #275)

Co-authored-by: Maxime Lafarie <5319267+maximelafarie@users.noreply.github.com>
@pepas24
Copy link

pepas24 commented Sep 14, 2023

@maximelafarie can this fix (and others) added to version 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants