-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog is not always shown on top of another dialog #275
Comments
I already created a pull request, because I found the bug: #274 |
Hi @be-ndee! Sorry for the late answer. Thank you very much for your PR, can you just please create a new one with your code rebased on the |
Thank you, I've created a new PR #290 |
* bugfix: dialog will be shown on top * bugfix: dialog will be shown on top * fix tests (issue #275) Co-authored-by: Maxime Lafarie <5319267+maximelafarie@users.noreply.github.com>
@maximelafarie can this fix (and others) added to version 7? |
I'm submitting a ... (check one with "x")
Current behavior
I have two dialogs. Dialog A and dialog B. I call
dialogA.open(true)
in dialog A. Then I close dialog A withdialogA.close()
. Then I open dialog B withdialogB.open(true)
. When dialog B is opened, I open dialog A aswell withdialogA.open(true)
. Dialog A will then be shown behind dialog B.Expected behavior
Dialog A should be shown on top dialog B, not behind it.
Reproduction of the problem Important is, that the dialog, which should be shown on top of another dialog, must have been opened and closed before the dialog underneath it. So you have to open and close dialog A, then open dialog B and open dialog A.
What is the motivation / use case for changing the behavior? It's a bug :-D
Please tell us about your environment:
Smart Modal version: 7.3.0
Angular version: 8.2.14
Browser: all
Language: all
The text was updated successfully, but these errors were encountered: