Skip to content

Commit

Permalink
s/golint/revive/
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew Pennebaker committed Oct 5, 2024
1 parent ac6be4c commit 8ada599
Show file tree
Hide file tree
Showing 13 changed files with 38 additions and 16 deletions.
1 change: 1 addition & 0 deletions cmd/tug/main.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Package main implements a CLI application to automate common docker buildx workflows.
package main

import (
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ go 1.23

require (
github.com/magefile/mage v1.14.0
github.com/mcandre/mage-extras v0.0.19
github.com/mcandre/mage-extras v0.0.20
)
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
github.com/magefile/mage v1.14.0 h1:6QDX3g6z1YvJ4olPhT1wksUcSa/V0a1B+pJb73fBjyo=
github.com/magefile/mage v1.14.0/go.mod h1:z5UZb/iS3GoOSn0JgWuiw7dxlurVYTu+/jHXqQg881A=
github.com/mcandre/mage-extras v0.0.19 h1:6xBSJ5eSmpgOdNoFe0X6JAhmeilCujVLJzOpCZ5vZqE=
github.com/mcandre/mage-extras v0.0.19/go.mod h1:zr+/cO9v8EtPmjHMVYx7ijYrbT3tfJSNgXc9ze6LJ4s=
github.com/mcandre/mage-extras v0.0.20 h1:hUw33CYkuyByVQW7eNv9E0gjTk2SMZ5Y8AWHdD4aVHM=
github.com/mcandre/mage-extras v0.0.20/go.mod h1:zr+/cO9v8EtPmjHMVYx7ijYrbT3tfJSNgXc9ze6LJ4s=
8 changes: 4 additions & 4 deletions magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ func GoFmt() error { return mageextras.GoFmt("-s", "-w") }
// GoImports runs goimports.
func GoImports() error { return mageextras.GoImports("-w") }

// GoLint runs golint.
func GoLint() error { return mageextras.GoLint() }

// GoVet runs default go vet analyzers.
func GoVet() error { return mageextras.GoVet() }

Expand All @@ -64,6 +61,9 @@ func Errcheck() error { return mageextras.Errcheck("-blank") }
// Nakedret runs nakedret.
func Nakedret() error { return mageextras.Nakedret("-l", "0") }

// Revive runs revive.
func Revive() error { return mageextras.Revive() }

// Shadow runs go vet with shadow checks enabled.
func Shadow() error { return mageextras.GoVetShadow() }

Expand All @@ -87,9 +87,9 @@ func Lint() error {
mg.Deps(GoVet)
mg.Deps(GoFmt)
mg.Deps(GoImports)
mg.Deps(GoLint)
mg.Deps(Errcheck)
mg.Deps(Nakedret)
mg.Deps(Revive)
mg.Deps(Shadow)
mg.Deps(Staticcheck)
mg.Deps(Unmake)
Expand Down
2 changes: 1 addition & 1 deletion makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ all:
go install github.com/kisielk/errcheck@v1.7.0
go install github.com/magefile/mage@v1.14.0
go install github.com/mcandre/factorio/cmd/factorio@v0.0.8
go install golang.org/x/lint/golint@latest
go install github.com/mgechev/revive@v1.4.0
go install golang.org/x/tools/cmd/deadcode@latest
go install golang.org/x/tools/cmd/goimports@latest
go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@latest
Expand Down
2 changes: 2 additions & 0 deletions tug.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// Package tug implements primitives to organize docker buildx operations.
package tug
2 changes: 2 additions & 0 deletions vendor/github.com/mcandre/mage-extras/mageextras.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions vendor/github.com/mcandre/mage-extras/magefile.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/github.com/mcandre/mage-extras/makefile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions vendor/github.com/mcandre/mage-extras/revive.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/github.com/mcandre/mage-extras/version.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/github.com/mcandre/mage-extras/vet.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# github.com/magefile/mage v1.14.0
## explicit; go 1.12
github.com/magefile/mage/mg
# github.com/mcandre/mage-extras v0.0.19
# github.com/mcandre/mage-extras v0.0.20
## explicit; go 1.23
github.com/mcandre/mage-extras

0 comments on commit 8ada599

Please sign in to comment.