test: ✅ add some test fixes #118
Triggered via pull request
September 15, 2024 11:42
Status
Failure
Total duration
26m 39s
Artifacts
–
customers.yml
on: pull_request
pre-check
4s
call-build-test
/
build-test
26m 15s
call-deploy
/
deploy
Annotations
9 errors and 11 warnings
FoodDelivery.Services.Customers.EndToEndTests.Customers.Features.GettingCustomerById.v1.GetCustomerByIdTests ► can returns valid response using valid id and auth credentials:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/Customers/Features/GettingCustomerById/v1/GetCustomerByIdTests.cs#L57
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/TestResults/test-results.trx
Error:
Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException : Expected response to satisfy one or more model assertions, but it wasn't:
- expectation has property x.Customer.FirstName that the other object does not have.
- expectation has property x.Customer.LastName that the other object does not have.
- expectation has property x.Customer.FullName that the other object does not have.
- expectation has property x.Customer.Created that the other object does not have.
The HTTP response was:
HTTP/1.1 200 OK
api-supported-versions: 1.0
Content-Type: application/json; charset=utf-8
Content-Length: 420
{
"customer": {
"id": "d170beb7-5b16-3911-5c33-2e1273d50e33",
"customerId": 1,
"identityId": "2585bd39-a80e-0e1f-7c29-67807483385b",
"email": "Johathan_Satterfield66@yahoo.com",
"name": "Braden Adams",
"country": "Colombia",
"city": "Lake Garrick",
"detailAddress": "45760 Maggio Route, Lake Eva, Yemen",
"nationality": "Global",
"birthDate": "2024-09-15T11:46:24.425\u002B00:00",
"phoneNumber": "(\u002B53)3603337355",
"createdAt": "0001-01-01T00:00:00"
}
}
The originating HTTP request was:
GET http://localhost/api/v1/customers/d170beb7-5b16-3911-5c33-2e1273d50e33 HTTP 1.1
Accept: application/json
Authorization: FakeBearer ***
Content-Length: 0
|
FoodDelivery.Services.Customers.EndToEndTests.Customers.Features.GettingCustomerById.v1.GetCustomerByIdTests ► must returns bad request status code with invalid:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/Customers/Features/GettingCustomerById/v1/GetCustomerByIdTests.cs#L140
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/TestResults/test-results.trx
Error:
Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException : Expected response to satisfy one or more model assertions, but it wasn't:
- expected pr.Title to be "ValidationException" with a length of 19, but "Validation Exception" has a length of 20, differs near " Ex" (index 10).
- expected pr.Type to be "https://tools.ietf.org/html/rfc7231#section-6.5.1" with a length of 49, but "https://tools.ietf.org/html/rfc9110#section-15.5.1" has a length of 50, differs near "911" (index 31).
The HTTP response was:
HTTP/1.1 400 BadRequest
api-supported-versions: 1.0
Content-Type: application/problem+json
Content-Length: 1068
{
"type": "https://tools.ietf.org/html/rfc9110#section-15.5.1",
"title": "Validation Exception",
"status": 400,
"detail": "\u0027Id\u0027 must not be empty.",
"instance": "GET /api/v1/customers/00000000-0000-0000-0000-000000000000",
"exception": {
"details": "BuildingBlocks.Core.Exception.Types.ValidationException",
"headers": {
"Accept": [
"application/json"
],
"Authorization": [
"FakeBearer ***"
],
"Host": [
"localhost"
]
},
"path": "/api/v1/customers/00000000-0000-0000-0000-000000000000",
"endpoint": "Get customer by id",
"routeValues": {
"id": "00000000-0000-0000-0000-000000000000",
"version": "1"
}
}
}
The originating HTTP request was:
GET http://localhost/api/v1/customers/00000000-0000-0000-0000-000000000000 HTTP 1.1
Accept: application/json
Authorization: FakeBearer ***
Content-Length: 0
|
FoodDelivery.Services.Customers.EndToEndTests.Customers.Features.GettingCustomerById.v1.GetCustomerByIdTests ► must returns not found status code when customer not exists:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/Customers/Features/GettingCustomerById/v1/GetCustomerByIdTests.cs#L108
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.EndToEndTests/TestResults/test-results.trx
Error:
Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException : Expected response to satisfy one or more model assertions, but it wasn't:
- expected pr.Title to be "CustomerNotFoundException" with a length of 25, but "Customer Not Found Exception" has a length of 28, differs near " No" (index 8).
- expected pr.Type to be "https://tools.ietf.org/html/rfc7231#section-6.5.4" with a length of 49, but "https://tools.ietf.org/html/rfc9110#section-15.5.5" has a length of 50, differs near "911" (index 31).
The HTTP response was:
HTTP/1.1 404 NotFound
api-supported-versions: 1.0
Content-Type: application/problem+json
Content-Length: 1154
{
"type": "https://tools.ietf.org/html/rfc9110#section-15.5.5",
"title": "Customer Not Found Exception",
"status": 404,
"detail": "Customer with id \u0027bf90d537-52b8-4b52-b296-21352f6d7112\u0027 not found.",
"instance": "GET /api/v1/customers/bf90d537-52b8-4b52-b296-21352f6d7112",
"exception": {
"details": "FoodDelivery.Services.Customers.Customers.Exceptions.Application.CustomerNotFoundException",
"headers": {
"Accept": [
"application/json"
],
"Authorization": [
"FakeBearer ***"
],
"Host": [
"localhost"
]
},
"path": "/api/v1/customers/bf90d537-52b8-4b52-b296-21352f6d7112",
"endpoint": "Get customer by id",
"routeValues": {
"id": "bf90d537-52b8-4b52-b296-21352f6d7112",
"version": "1"
}
}
}
The originating HTTP request was:
GET http://localhost/api/v1/customers/bf90d537-52b8-4b52-b296-21352f6d7112 HTTP 1.1
Accept: application/json
Authorization: FakeBearer ***
Content-Length: 0
|
FoodDelivery.Services.Customers.IntegrationTests.Users.Features.RegisteringUser.v1.Events.External.UserRegisteredTests ► should create new customer in postgres write db when after consuming message:
tests/Shared/Tests.Shared/Fixtures/SharedFixture.cs#L422
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.IntegrationTests/TestResults/test-results.trx
Error:
System.AggregateException : One or more errors occurred. (Condition not met for the test in the 'True' second.) (A task was canceled.)
---- System.TimeoutException : Condition not met for the test in the 'True' second.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
|
FoodDelivery.Services.Customers.IntegrationTests.Users.Features.RegisteringUser.v1.Events.External.UserRegisteredTests ► should create new mongo customer read model in the mongodb after consuming message:
tests/Shared/Tests.Shared/Fixtures/SharedFixture.cs#L422
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.IntegrationTests/TestResults/test-results.trx
Error:
System.AggregateException : One or more errors occurred. (Condition not met for the test in the 'True' second.) (A task was canceled.)
---- System.TimeoutException : Condition not met for the test in the 'True' second.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
|
FoodDelivery.Services.Customers.IntegrationTests.Users.Features.RegisteringUser.v1.Events.External.UserRegisteredTests ► should save customer created integration event in the outbox after consuming message:
tests/Shared/Tests.Shared/Fixtures/SharedFixture.cs#L422
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.IntegrationTests/TestResults/test-results.trx
Error:
System.AggregateException : One or more errors occurred. (Condition not met for the test in the 'True' second.) (A task was canceled.)
---- System.TimeoutException : Condition not met for the test in the 'True' second.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
|
FoodDelivery.Services.Customers.IntegrationTests.Users.Features.RegisteringUser.v1.Events.External.UserRegisteredTests ► should save mongo customer read model in internal persistence message after consuming message:
tests/Shared/Tests.Shared/Fixtures/SharedFixture.cs#L422
Failed test found in:
tests/Services/Customers/FoodDelivery.Services.Customers.IntegrationTests/TestResults/test-results.trx
Error:
System.AggregateException : One or more errors occurred. (Condition not met for the test in the 'True' second.) (A task was canceled.)
---- System.TimeoutException : Condition not met for the test in the 'True' second.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.
|
call-build-test / build-test
Failed tests were found and 'fail-on-error' option is set to true
|
call-build-test / build-test
This action finished successfully, but test results have status failure.
|
pre-check
The following actions use a deprecated Node.js version and will be forced to run on node20: webiny/action-conventional-commits@v1.1.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Domain/IHaveIdentity.cs#L6
Possible null reference return.
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Events/EventEnvelopeMetadata.cs#L8
Single-line comment should be preceded by blank line (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1515.md)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Messaging/IIntegrationEventHandler.cs#L5
Rename type name IIntegrationEventHandler so that it does not end in 'EventHandler' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Web/Module/IModuleConfiguration.cs#L4
Rename namespace BuildingBlocks.Abstractions.Web.Module so that it no longer conflicts with the reserved language keyword 'Module'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Events/IDomainEventHandler.cs#L3
Rename type name IDomainEventHandler so that it does not end in 'EventHandler' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Events/IEventHandler.cs#L5
Rename type name IEventHandler so that it does not end in 'EventHandler' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Events/Internal/IDomainNotificationEventHandler.cs#L3
Rename type name IDomainNotificationEventHandler so that it does not end in 'EventHandler' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Web/Storage/IRequestStorage.cs#L8
Rename virtual/interface member IRequestStorage.Get<T>(string) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Web/Storage/IRequestStorage.cs#L5
Rename virtual/interface member IRequestStorage.Set<T>(string, T) so that it no longer conflicts with the reserved language keyword 'Set'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
call-build-test / build-test:
src/BuildingBlocks/BuildingBlocks.Abstractions/Core/IIdGenerator.cs#L5
Rename virtual/interface member IIdGenerator<TId>.New() so that it no longer conflicts with the reserved language keyword 'New'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|