refactor(metrics): use dims instead of creating new metrics

meirim-org · Feb 4, 2024 · c1ee700 · c1ee700
1 parent 3b8e474
commit c1ee700
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/server/bin/dummy_job b/server/bin/dummy_job
@@ -9,7 +9,7 @@ async function run() {
 }
 
 async function main(){
-    await runAndReport({func: run, metricName: "dummy_job"})
+    await runAndReport({func: run, name: "dummy_job"})
 }
 
 main()
diff --git a/server/metrics.js b/server/metrics.js
@@ -31,27 +31,35 @@ const report = async ({ metricName, unit = "None", value = 1.0, dims = [] }) =>
     };
 
 
-async function runAndReport({metricName, func}) {
+async function runAndReport({name, func}) {
     try {
         const res = await func()
         report({ 
-            metricName,
+            metricName: "job",
             dims: [
                 {
                     Name: "result",
                     Value: "success",
-                }
+                },
+                {
+                    Name: "component",
+                    Value: name,
+                },
             ]
         })
         return res
     } catch (e) {
         report({ 
-            metricName,
+            metricName: "job",
             dims: [
                 {
                     Name: "result",
                     Value: "failed",
-                }
+                },
+                {
+                    Name: "component",
+                    Value: name,
+                },
             ]
         })
         throw e