Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand literal function descriptor language [in progress] #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sritchie
Copy link
Member

Full port of litfun.scm and the function descriptor language from scmutils.

== Literal Function Descriptor Language

We support some of the possible literal function types; these are type signatures like (-> (UP Real Real) Real). But litfun.scm has support for a richer language.

  • study litfun.scm and port the full scope of function descriptor language, including lots of helper functions like Lagrangian. There are also many examples here that would make great tests. This can live in emmy.abstract.function.cljc
  • there is also a "typed function" we don't have that would be interesting to study.
  • Forms like (UP* Real) should work, with no explicit arity.
  • add 0-arity of Hamiltonian back in: ([] '(-> (UP Real (UP* Real) (DOWN* Real)) Real))
  • add 0-arity of Lagrangian back in: ([] '(-> (UP Real (UP* Real) (UP* Real)) Real)). the current impl can't handle stars with no numbers.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.97% and project coverage change: -0.32 ⚠️

Comparison is base (7631909) 86.45% compared to head (bb1f22e) 86.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   86.45%   86.14%   -0.32%     
==========================================
  Files          99       99              
  Lines       15306    15379      +73     
  Branches      785      785              
==========================================
+ Hits        13233    13248      +15     
- Misses       1288     1346      +58     
  Partials      785      785              
Impacted Files Coverage Δ
src/emmy/abstract/function.cljc 63.25% <25.97%> (-20.55%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants