Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to key concept renaming #6

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

m-chrzan
Copy link
Contributor

This is a follow up to #4 after @chapati23's comments.

  • Removes an erroneous heading comment
  • Renames allowedDeviation to allowedDeviationNumerator
  • Specifies the behavior of allowedDeviationNumerator according to the discussion here.

@m-chrzan m-chrzan changed the title Follow up to core concept renaming Follow up to key concept renaming May 15, 2024
@chapati23 chapati23 merged commit f41212b into main May 15, 2024
1 check failed
@chapati23 chapati23 deleted the m-chrzan/rename-pr-fixes branch May 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants