Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DataPlatform.cs: Add admins and key vault secret #16

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

merca
Copy link
Owner

@merca merca commented Oct 13, 2023

  • Add Pulumi namespace
  • Add admins dictionary with two entries
  • Create AzKeyVault instance with admins and a secret

- Add `Pulumi` namespace
- Add `admins` dictionary with two entries
- Create `AzKeyVault` instance with admins and a secret
@merca merca added the enhancement New feature or request label Oct 13, 2023
@merca merca temporarily deployed to production October 13, 2023 18:30 — with GitHub Actions Inactive
@merca merca enabled auto-merge (squash) October 13, 2023 18:30
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Test Results

12 tests   12 ✔️  0s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit f75bfc5.

♻️ This comment has been updated with latest results.

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 13, 2023

🥷 Code experts: no user but you matched threshold 10

merca has most 👩‍💻 activity in the files.
merca has most 🧠 knowledge in the files.

See details

src/stargripcorp.dataplatform.infra.azure/Infrastructure/DataPlatform.cs

Activity based on git-commit:

merca
OCT 29 additions & 15 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
merca: 100%

To learn more about /:\ gitStream - Visit our Docs

@pulumi
Copy link

pulumi bot commented Oct 13, 2023

🍹 The Update (preview) for merca/stargripcorp/current was successful.

Resource Changes

    Name                                                    Type                                       Operation
+   merca-data-dev-ra-3a668e53-336b-4d30-94bf-6620cdd036ec  azure-native:authorization:RoleAssignment  create
+   merca-data-dev-ra-f5d889ea-e64e-467a-9240-f875ff284c04  azure-native:authorization:RoleAssignment  create
+   data-kv                                                 pkg:azure:keyvault                         create
+   merca-data-dev-secret                                   azure-native:keyvault:Secret               create
+   merca-data-dev-kv                                       azure-native:keyvault:Vault                create

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 13, 2023

🥷 Code experts: no user but you matched threshold 10

merca has most 👩‍💻 activity in the files.
merca has most 🧠 knowledge in the files.

See details

src/stargripcorp.dataplatform.infra.azure/Infrastructure/DataPlatform.cs

Activity based on git-commit:

merca
OCT 29 additions & 15 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
merca: 100%

To learn more about /:\ gitStream - Visit our Docs

@merca merca merged commit 316a1c3 into current Oct 13, 2023
12 of 14 checks passed
@merca merca deleted the feature/add-keyvault-to-data-platform branch October 13, 2023 18:31
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 13, 2023

Hello merca 👋 Thanks for making your first PR, and welcome to our project!
Our mentor team has automatically been assigned to review this PR and guide you through the process.
Please reach out to that team if you have questions about the next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant