Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'n' from the name flag #86

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

Aijeyomah
Copy link
Contributor

@Aijeyomah Aijeyomah commented Jan 7, 2025

Notes for Reviewers

This PR fixes #

  • Remove the name option with a single letter -n
  • Update the asset location to point to the directory action-assets/helm-plugin-assets
  • fix golangci checking some pakages from toochain by exclude external packages in golangci-lint

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9892d52) to head (e85764d).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
cmd/kanvas-snapshot/cmd.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #86    +/-   ##
=======================================
  Coverage        0   0.00%            
=======================================
  Files           0       4     +4     
  Lines           0     219   +219     
=======================================
- Misses          0     219   +219     
Flag Coverage Δ
unittests 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,7 @@
module github.com/meshery/helm-kanvas-snapshot

go 1.21.8
go 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cmd/kanvas-snapshot/cmd.go Outdated Show resolved Hide resolved
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
@leecalcote leecalcote merged commit 0b8a1ce into meshery:master Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants