Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of online source when multiple transfer options block are used #393

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

tylerjmchugh
Copy link
Contributor

@tylerjmchugh tylerjmchugh commented Aug 9, 2024

This PR addresses the issue of removing or updating online resources when there are multiple transferOptions elements for HNAP records.

Applies the changes made to iso19139 on the iso19139.ca.HNAP schema.

Depends on the following:

@ianwallen ianwallen requested a review from josegar74 August 19, 2024 23:49
@josegar74
Copy link
Contributor

josegar74 commented Aug 20, 2024

@ianwallen in the original PR, this file is changed: https://github.com/geonetwork/core-geonetwork/pull/8281/files#diff-5874e357bf25f7130014d5a217c01c48467127e5134ceb03bc2d20f8db5a3af1, but I don't see it updated in the HNAP pull request, is that ok?

Sorry, I see it relies in the ISO file

Copy link
Contributor

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine

@ianwallen ianwallen merged commit 3f7ed80 into metadata101:4.2.x Aug 20, 2024
@ianwallen ianwallen added this to the 4.2.11 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants