Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dates.py 2024->2025 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JebronLames32
Copy link

Current code is generating ics starting from Jan 2, 2024. Replaced this date to Jan 2, 2025

Update dates.py to generate year as 2025, replacing 2024
@proffapt
Copy link
Member

@shikharish @rohan-b-84 I have lost track on the development of this, are there any other changes required?

@shikharish
Copy link
Member

@JebronLames32 The dates have to updated from the academic calendar. Just changing 2024->2025 won't do.

@JebronLames32
Copy link
Author

@shikharish All the dates seem to be hardcoded. I saw that there was a PR in the original gyft repository Pull Request #147 which addresses this issue but not completely I think. the hardcoding part of the start and end dates still has to be changed. A similar fix can be incorporated here as well.
Changing the date from 2024 to 2025 seemed like a temporary fix for this issue as it does not seem to be taking any holidays into account while making the ics and provided me an accurate looking schedule.

@shikharish
Copy link
Member

shikharish commented Dec 31, 2024

The correct dates for midsem and endsem exams is still wrong and the timetable won't be fully correct. For now, you can hardcode the actual dates from the academic calendar.
And if you are interested in implementing the parsing part, feel free to open an issue for it! Thanks.

@JebronLames32
Copy link
Author

Sure! Will take a look at it

@proffapt
Copy link
Member

proffapt commented Jan 2, 2025

The parsing part is on another PR. You don't have to look at it, update the latest dates from the calendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants