Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy for file ops. #2997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meowjesty
Copy link
Member

@meowjesty meowjesty commented Jan 1, 2025

pub read_write: HashSet<String>,

#[serde(default)]
pub local: HashSet<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would local do? client will see that and fallback to local?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, but not what I had in mind.

I thought that local here would mean that this file has to be read locally, so the operator returns NotFound if the user does not put it under config.fs.local.

Returning a OpenLocal (or something like that) and having mirrord turn this open call into a local one would be neat. Should I do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants