Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Publish to docker.io and use public repos #7

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

darinspivey
Copy link
Contributor

This commit prepares this repository to become the only place where vector changes are done. The difference is that it will publish images to docker.io where we can then use for Edge as well as our SaaS product. This will require us to change our SaaS images to source from dockerhub instead of gcr, but this is the first step towards that.

There were also changes to use public-only repos for dependencies. This allows us to remove lots of github auth steps that are no longer needed. This commit completely re-works Jenkinsfile to work from a public-only repository standpoint.

Ref: LOG-18250

This commit prepares this repository to become the only place where
vector changes are done. The difference is that it will publish images
to `docker.io` where we can then use for Edge as well as our SaaS
product. This will require us to change our SaaS images to source from
dockerhub instead of gcr, but this is the first step towards that.

There were also changes to use public-only repos for dependencies. This
allows us to remove lots of github auth steps that are no longer needed.
This commit completely re-works `Jenkinsfile` to work from a public-only
repository standpoint.

Ref: LOG-18250
Comment on lines +202 to +211
def semver = npm.semver()
if (version_before != semver.version) {
buildx.build(
project: PROJECT_NAME
, push: true
, tags: [semver.version]
, dockerfile: "distribution/docker/mezmo/Dockerfile"
, docker_repo: DOCKER_REPO
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step appears to be missing the bits to publish the MTP (what ./release-tool publish was doing). is that something we're going to add back? or maybe I'm just missing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that might have been missed. Checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is actually 2 things:

  1. use buildx and docker.io for images
  2. Changes to support primary development off of this repo (ie use the resulting image in our SaaS)

I think we can go ahead and merge this to accomplish the first thing. It will fix a few nasty errors as it relates to keeping this repo in sync with the private one. At a later time, there still has to be work to cut over the k8s manifest to using the new image, so at that time, we can add these missing MTP publishing bits. Just don't wanna be blocked here now because of that. Adding those steps might require tooling changes since everything has used release-tool in the recent past. If that's the case, then we won't switch to this repo as our primary any time soon, but at least it'll be easy to merge with our private repo.

@darinspivey darinspivey marked this pull request as draft March 28, 2024 18:17
@darinspivey darinspivey marked this pull request as ready for review March 28, 2024 18:40
@darinspivey darinspivey merged commit 7f3158e into master Apr 3, 2024
12 checks passed
@darinspivey darinspivey deleted the darinspivey/LOG-18250 branch April 3, 2024 18:03
logdnabot added a commit that referenced this pull request Apr 3, 2024
## [3.13.4](v3.13.3...v3.13.4) (2024-04-03)

### Chores

* **ci**: Publish to `docker.io` and use public repos [631a8ab](631a8ab) - Darin Spivey [LOG-18250](https://logdna.atlassian.net/browse/LOG-18250)

### Miscellaneous

* Merge pull request #7 from mezmo/darinspivey/LOG-18250 [7f3158e](7f3158e) - GitHub [LOG-18250](https://logdna.atlassian.net/browse/LOG-18250)
@logdnabot
Copy link
Contributor

🎉 This PR is included in version 3.13.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants