Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original bofnet_stracciatella_script command uses bofnet_executeassembly, which is blocking. I think this means that if the script is bigger than 20000 bytes (and a named pipe will be used), the command will block (while waiting on the named pipe), at the same time, preventing the writepipe function from sending the actual script. This is causing deadlock? that breaks the beacon or at least prevents it from returning until a certain timeout period.
I renamed the bofnet_stracciatella_script to bofnet_executestracciatella_script, as the naming makes more sense. And added a warning that scripts > 20000 bytes are not supported.
Addtionally, I added new bofnet_stracciatella_script command that uses bofnet_jobassembly, and will be able to handle scripts > 20000 bytes