Merge pull request #17 from miaowware/revert-props

revert renaming of property setters in 1a460d4
miaowware · Sep 27, 2021 · 3b19534 · 3b19534
2 parents c3b19f9 + 9b9baa0
commit 3b19534
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/callsignlookuptools/common/abcs.py b/callsignlookuptools/common/abcs.py
@@ -17,14 +17,14 @@ class LookupAbc(ABC):
     def __init__(self):
         pass
 
-    @property
+    @property  # type: ignore[misc]
     @abstractmethod
     def session(self):
         pass
 
-    @session.setter  # type: ignore[attr-defined] # python/mypy#1465
+    @session.setter  # type: ignore[misc]
     @abstractmethod
-    def set_session(self, val):
+    def session(self, val):
         pass
 
     @abstractmethod
@@ -57,8 +57,8 @@ def username(self) -> str:
         """
         return self._username
 
-    @username.setter  # type: ignore[attr-defined] # python/mypy#1465
-    def set_username(self, val: str) -> None:
+    @username.setter
+    def username(self, val: str) -> None:
         self._username = val
 
     @property
@@ -70,8 +70,8 @@ def password(self) -> str:
         """
         return self._password
 
-    @password.setter  # type: ignore[attr-defined] # python/mypy#1465
-    def set_password(self, val: str) -> None:
+    @password.setter
+    def password(self, val: str) -> None:
         self._password = val
 
     @property
@@ -83,8 +83,8 @@ def useragent(self) -> str:
         """
         return self._useragent
 
-    @useragent.setter  # type: ignore[attr-defined] # python/mypy#1465
-    def set_useragent(self, val: str) -> None:
+    @useragent.setter
+    def useragent(self, val: str) -> None:
         self._useragent = val
 
     @property
@@ -96,8 +96,8 @@ def session_key(self) -> str:
         """
         return self._session_key
 
-    @session_key.setter  # type: ignore[attr-defined] # python/mypy#1465
-    def set_session_key(self, val: str) -> None:
+    @session_key.setter
+    def session_key(self, val: str) -> None:
         self._session_key = val
 
     @abstractmethod

diff --git a/callsignlookuptools/common/mixins.py b/callsignlookuptools/common/mixins.py
@@ -55,8 +55,8 @@ def session(self) -> requests.Session:
             """
             return self._session
 
-        @session.setter  # type: ignore[attr-defined] # python/mypy#1465
-        def set_session(self, val: requests.Session):
+        @session.setter
+        def session(self, val: requests.Session):
             self._session = val
 
 
@@ -96,8 +96,8 @@ def session(self) -> Optional[aiohttp.ClientSession]:
             """
             return self._session
 
-        @session.setter  # type: ignore[attr-defined] # python/mypy#1465
-        def set_session(self, val: Optional[aiohttp.ClientSession]):
+        @session.setter
+        def session(self, val: Optional[aiohttp.ClientSession]):
             self._session = val
 
         async def start_session(self):