v6 release #79
Merged
v6 release #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelastic
reviewed
Dec 11, 2024
pixelastic
reviewed
Dec 11, 2024
pixelastic
reviewed
Dec 11, 2024
pixelastic
reviewed
Dec 11, 2024
src/index.js
Outdated
| const b = pixels[offset + 2] | ||
| const a = pixels[offset + 3] | ||
|
|
||
| if ((a === undefined || a >= 125) && !(r > 250 && g > 250 && b > 250)) { |
There was a problem hiding this comment.
I think this code excludes black and white pixels. Any reason why we're doing that?
There was a problem hiding this comment.
This is interesting; it's in the original colorthief implementation
https://github.com/lokesh/color-thief/blob/master/src/color-thief-node.js#L17
Kikobeats
force-pushed
the
v6
branch
4 times, most recently
from
f12809a to
b02c94c
Compare
Kikobeats
force-pushed
the
v6
branch
2 times, most recently
from
c740654 to
657feb2
Compare
Kikobeats
force-pushed
the
v6
branch
3 times, most recently
from
cd3f349 to
9dd3f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.