Better sampling override behavior #4014
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://portal.microsofticm.com/imp/v5/incidents/details/577578458/summary
Currently, this configuration:
has the unexpected effect of capturing 50% of
select count(*) from abc
calls, even when they occur within the excluded health check.this PR updates the behavior so that when a sampling override percentage is <100 and a parent dropped, then the span (with override percentage < 100) will also be dropped
TODO need to decide whether this affects statistical accuracy of item count
THOUGHT when parent span isn't sampled, it's a no-op, and so has no "sample rate" attribute available for children to check