Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splat function argument #6747

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Splat function argument #6747

merged 3 commits into from
Jul 19, 2024

Conversation

s-perron
Copy link
Collaborator

@s-perron s-perron commented Jul 5, 2024

When a scalar variable is passed as the argument to an inout vector parameter,
then the scalar is suppose to be splatted. After returning from the
function, we need to extract the first element from the parameter to
store back into the scalar.

Fixes #6568

@s-perron s-perron requested a review from a team as a code owner July 5, 2024 13:57
@s-perron s-perron requested review from cassiebeckley and Keenuts July 5, 2024 13:58
@s-perron s-perron changed the title Splat funciton argument Splat function argument Jul 16, 2024
Copy link
Collaborator

@sudonatalie sudonatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

s-perron added 3 commits July 19, 2024 11:06
When a scalar variable is passed as the argument to an inout vector parameter,
then the scalar is suppose to be splatted. After returning from the
function, we need to extract the first element from the parameter to
store back into the scalar.

Fixes microsoft#6568
@s-perron s-perron merged commit 74ba845 into microsoft:main Jul 19, 2024
12 checks passed
@s-perron s-perron deleted the i6568 branch September 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[SPIR-V] DXC crash
3 participants