Release Note for OS-normalized include paths #6789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior was changed with microsoft#6317 so that regardless of spelling in the shader, the include path will conform to the host OS style for the purposes of the include handler. This just adds a release note for that new behavior. Fixes microsoft#6669
python3kgae
approved these changes
Jul 16, 2024
|
@python3kgae - have you done the final merge of main -> release for July release? If so then we'll need to cherry-pick this into release. |
damyanp
approved these changes
Jul 16, 2024
tex3d
approved these changes
Jul 16, 2024
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Jul 16, 2024
The behavior was changed with microsoft#6317 so that regardless of spelling in the shader, the include path will conform to the host OS style for the purposes of the include handler. This just adds a release note for that new behavior. Fixes microsoft#6669 (cherry picked from commit 9fa4618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior was changed with #6317 so that regardless of spelling in the shader, the include path will conform to the host OS style for the purposes of the include handler. This just adds a release note for that new behavior.
Fixes #6669