[NFC] Move DxilValidation to a dedicated folder. #6849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move DxilValidation out of HLSL. This is a preparatory step for microsoft#6817.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bob80905
reviewed
Aug 7, 2024
bob80905
reviewed
Aug 7, 2024
bob80905
approved these changes
Aug 7, 2024
|
Is this code really moved or is it copied from somewhere? I see a lot of code being added, but not removed from anywhere. |
The code is moved around and spited into different files. |
damyanp
reviewed
Aug 13, 2024
damyanp
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move DxilValidation out of HLSL.
Also move code to validate dxil container into DxilContainerValidation.cpp from DxilValidation.cpp.
This is a preparatory step for #6817.