Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ViewID] build viewid mask for primitive output #6886

Merged
merged 5 commits into from
Sep 5, 2024
Merged

[ViewID] build viewid mask for primitive output #6886

merged 5 commits into from
Sep 5, 2024

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Aug 28, 2024 •
edited
Loading

Currently, viewid mask for primitive output is always empty. This change will fix it by treat entry as PC entry and skip output when it is not what is checking.

For #6817

@python3kgae
[ViewID] build viewid mask for primitive output
57ad149 
Currently, viewid mask for primitive output is always empty.
This change will fix it by treat entry as PC entry.

For microsoft#6817
@python3kgae python3kgae requested a review from a team as a code owner August 28, 2024 22:07
@python3kgae python3kgae requested a review from tex3d August 28, 2024 22:08
tex3d
tex3d approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, even if it feels slightly odd.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

damyanp
damyanp requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing coverage for this needs to be improved since some clearly incorrect code managed to slip through.

@python3kgae
Copy link
Contributor Author

Testing coverage for this needs to be improved since some clearly incorrect code managed to slip through.

It is dead code which cannot make any different output.

@python3kgae python3kgae enabled auto-merge (squash) September 5, 2024 18:07
@python3kgae python3kgae merged commit 72f306c into microsoft:main Sep 5, 2024
12 checks passed
@python3kgae python3kgae deleted the viewid_mask_prim branch September 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanp damyanp damyanp approved these changes

@tex3d tex3d tex3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@python3kgae @tex3d @damyanp