[NFC] update print functions for PSV #6887
Conversation
Update print functions to share with validation. For microsoft#6817
|
I don't understand why this change is being made. Can you add some explanation please to the description? Is this just refactoring? If so, why? Or is there actually some functional change in here? |
| Print(OS, GetSemanticName()); | ||
| } | ||
|
|
||
| void PSVSignatureElement::Print(raw_ostream &OS, const char *Name) const { |
There was a problem hiding this comment.
I'm trying to figure out the motivation for this change? Is there some place now where we want a name other than what GetSemanticName() returns to be displayed?
There was a problem hiding this comment.
It is for validation to print Signature Element where SemanticName is not in StringTable.
There was a problem hiding this comment.
I guess I don't have enough context to understand what that means. So sometimes PSVSignatureElement doesn't contain the data it needs?
There was a problem hiding this comment.
It is for emit error message on a PSVSignatureElement generated from DxilSiginatureElement which doesn't have SemanticName setup. The SemanticName will be get from the DxilSiginatureElement.
There was a problem hiding this comment.
This may be a case of PR being sliced too far away from the code that makes it possible to understand the change.
Update print functions to share with validation.
This change is part of a big change for #6817 where the print function is shared between the DxilPipelineStateValidation::Print and the psv content validation.
Move this change out of the big change to help review.
For #6817