Disable the aggressive reassociation optimization by default #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aggressive reassociation optimization for this common factor issue (#6593) can reduce redundant calculations obviously. But it also exposed some issues for the final codegen and caused perf regressions for some shaders in runtime tests. Fixing those codegen issues is non-trival, as a workaround, this PR disables the aggressive reassociation optimization by default and will get the perf loss back.
|
Is this reverting a recently made change? |
No. It just turns off the change by default. |
lizhengxing
deleted the
user/zhengxing/disable-aggressive-common-factor-optimization-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggressive reassociation optimization for this common factor issue (#6593) can reduce redundant calculations obviously.
But it also exposed some issues for the final codegen and caused perf regressions for some shaders in runtime tests.
Fixing those codegen issues is non-trival, as a workaround, this PR disables the aggressive reassociation optimization by default and will get the perf loss back.