Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug.printf dxil intrinsic support #6899

Closed
wants to merge 1 commit into from
Closed

Conversation

jiaolu
Copy link
Contributor

@jiaolu jiaolu commented Sep 5, 2024

No description provided.

@jiaolu jiaolu requested a review from a team as a code owner September 5, 2024 08:41
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@jiaolu jiaolu force-pushed the main branch 5 times, most recently from 83b807c to 90e9a62 Compare September 5, 2024 13:44
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ With the latest revision this PR passed the Python code formatter.

@jiaolu jiaolu force-pushed the main branch 4 times, most recently from 0cac1f2 to a48593a Compare September 6, 2024 09:41
Add debug.printf dxil intrinsic, the dxil opcode is 258
@jiaolu
Copy link
Contributor Author

jiaolu commented Sep 11, 2024

ping for review

@damyanp
Copy link
Member

damyanp commented Sep 11, 2024

Thank you for your contribution. Unfortunately, we cannot accept this PR as it is, since it is adding a new DXIL operation that hasn't been proposed or discussed with the team.

You can find out more about our contribution guidelines here: https://github.com/microsoft/DirectXShaderCompiler/blob/main/CONTRIBUTING.md

The process for proposing new DXIL operations is to submit a proposal for a shader model feature using this template . You can find out more about our HLSL design process here.

@damyanp damyanp closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants