Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vk-allow-rwstructuredbuffer-arrays, and remove option #6903

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

s-perron
Copy link
Collaborator

@s-perron s-perron commented Sep 6, 2024

We have done all of the development on this feature that we will do.

We cannot handle Multidimentional arrays of these buffers because Vulkan
does not allow it.

We cannot handle arrays that are in a struct if the counter variable is
used. We have tests cases to identify those cases.

Closes #5440

We have done all of the development on this feature that we will do.

We cannot handle Multidimentional arrays of these buffers because Vulkan
does not allow it.

We cannot handle arrays that are in a struct if the counter variable is
used. We have tests cases to identify those cases.

Closes microsoft#5440
@s-perron s-perron requested a review from a team as a code owner September 6, 2024 19:34
@s-perron s-perron enabled auto-merge (squash) September 6, 2024 19:36
@s-perron
Copy link
Collaborator Author

s-perron commented Sep 9, 2024

FYI: @EpicJeanNoeMorissette

@s-perron s-perron merged commit 496482c into microsoft:main Sep 10, 2024
13 checks passed
@s-perron s-perron deleted the buffer_arrays branch September 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[SPIRV] Handle arrays of RWStructuredBuffers, AppendStructuredBuffers, and ConsumeStructuredBuffers
3 participants