-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some small improvements to docs and tools around running tests locally against real services #23387
base: main
Are you sure you want to change the base?
Conversation
against real services This reverts commit 0882ca4.
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
@@ -146,7 +148,8 @@ | |||
"fluid__test__driver": "r11s", | |||
"fluid__test__backCompat": "${input:backCompat}", | |||
"fluid__test__r11sEndpointName": "${input:r11sEndpoint}", | |||
"FLUID_TEST_VERBOSE": "${input:verboseConsoleOutputt}", | |||
"FLUID_TEST_VERBOSE": "${input:verboseConsoleOutput}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abe27342 I guess this will block the fallthrough to the local environment variables, so probably shouldn't merge this as-is. Any ideas on how to organize/implement this to make it quick/easy to plug them in on CodeSpaces or another place where getkeys hasn't been run on the local machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like https://github.com/microsoft/FluidFramework/pull/23387/files#r1913828487 is probably the best we can do. launch targets aren't super feature-rich.
It's fine to leave around the extra bits you added under "inputs"--as long as they aren't used by any launch targets, they won't be prompted for. You could maybe put a comment there instead explaining they're useful for codespaces workflows.
"login__odsp__test__tenants": "${input:login__odsp__test__tenants}", | ||
"login__microsoft__clientId": "${input:login__microsoft__clientId}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"login__odsp__test__tenants": "${input:login__odsp__test__tenants}", | |
"login__microsoft__clientId": "${input:login__microsoft__clientId}", | |
// Normally these environment variables would be populated by getkeys, | |
// but if that is unfeasible (e.g. due to codespaces), uncomment these lines | |
// and you can input them at launch time. | |
// "login__odsp__test__tenants": "${input:login__odsp__test__tenants}", | |
// "login__microsoft__clientId": "${input:login__microsoft__clientId}", |
Description