fix(client-presence): disabled (failing) attendees unit tests #23419
+96
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
packages/framework/presence/src/test/presenceManager.spec.ts:83
- The word 'seassionId-2' is misspelled. It should be 'sessionId-2'.
presence = prepareConnectedPresence(runtime, "seassionId-2", "client2", clock, logger);
packages/framework/presence/src/systemWorkspace.ts:202
- The newly introduced behavior for handling stale connections using 'staleConnectionTimer' is not covered by tests.
this.staleConnectionTimer.setTimeout(() => {
jason-ha
reviewed
Jan 9, 2025
Comment on lines
203
to
207
| for (const client of this.staleConnectionClients) { | ||
| // Mark the client as disconnected and remove from the stale connection set | ||
| if (client.getConnectionStatus() === SessionClientStatus.Connected) { | ||
| client.setDisconnected(); | ||
| this.events.emit("attendeeDisconnected", client); |
There was a problem hiding this comment.
- why do we need the connected check? Because we don't remove them from set when they disconnect in the meantime?
- we prefer to update states to consistent point and then announce events in a group. That way anything responding to the first event and looking at state will get the final state. (This preference assumes that nothing interrupts the thread which is true for JavaScript without any yields.)
So, if we remove the status check, then the state set and events can be done in two simple loops.
There was a problem hiding this comment.
Yes, the idea was not to double emit 'attendeeDisconnected'. But I changed to remove attendee from set when they are disconnected/their connection is removed. Also updated to announce attendeeDisconnected's in group after they are all set.
Comment on lines
457
to
+459
| presence.events.on("attendeeDisconnected", (attendee) => { | ||
| disconnectedAttendees.push(attendee); | ||
| if (attendee !== presence.getMyself()) { | ||
| remoteDisconnectedAttendees.push(attendee); |
There was a problem hiding this comment.
So, we announce ourselves when disconnecting. Do we have a test for that? I don't think we do, but we should. Task for after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADO Bug 24395
This PR enables the previously failing tests presence attendee tests as well as the new ones added in this PR: #23351
When the local attendee disconnects, we temporarily lose connectivity status for remote attendees. To fix this we mark all 'Connected' remote attendee connections as stale upon reconnect and update their status to disconnected after 30 seconds of inactivity.
This PR also fixes some spelling mistakes: "seassionId-2" to "sessionId-2"