-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gitrest docker build install with a frozen lockfile #23535
Make gitrest docker build install with a frozen lockfile #23535
Conversation
… rationale comments
…s a dependency on 'base' and 'runner'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- server/gitrest/Dockerfile: Language not supported
- server/gitrest/package.json: Language not supported
Sample build here: https://dev.azure.com/fluidframework/internal/_build/results?buildId=316564&view=results Plan is to transition other server pipelines to a similar structure, but I want a bit more e2e verification first. |
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f87a4bf
to
c5ed19f
Compare
ok, finally got e2e tests working. looks healthy--https://dev.azure.com/fluidframework/internal/_build/results?buildId=316917&view=results (note the LTS build is from a previous attempt that didn't get requeued as I didn't bother, therefore pass rate much lower than usual) |
Description
Main desirable change: updates the gitrest docker build to copy
.npmrc
within the docker container before installing, which ensures the subsequent install includesfrozen-lockfile=true
.Fallout from this desire: the previous CI setup for docker builds involved using
flub
to set the package version before the docker build. This makespnpm install
with frozen lockfile fail, since the dependency versions of packages within the workspace will be whatever that package version was set to, rather than the version within source control. To fix this, I've updated the docker build to support setting the package version from within the docker container usingflub
, and plumbed through necessary variables in CI to make that possible.Also includes some minor quality improvements to the docker build, such as fixing up deprecated syntax warnings, using a cache mount for the pnpm dependencies, and reducing the footprint of the
runner
build slightly (there's still much more that could be done in that area if we care to invest: we keep around dev deps, for example).AB#26779