-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and reorganize stashed ops that wait for a summary #23542
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
packages/test/test-end-to-end-tests/src/test/offline/offlineTestsUtils.ts:43
- [nitpick] The magic number
30
should be defined as a constant or passed as a parameter for better readability and maintainability.
const lots = 30;
packages/test/test-end-to-end-tests/src/test/offline/containerDirtyFlag.spec.ts:31
- Ensure that map2 is properly initialized before using it. Add a check to verify that map2 is not null or undefined.
const map2 = await dataStore2.getSharedObject<ISharedMap>(mapId);
export async function loadOffline( | ||
testContainerConfig: ITestContainerConfig, | ||
testObjectProvider: ITestObjectProvider, | ||
request: IRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request
parameter should be validated to ensure it is not null or undefined before being used.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Some tests among stashedOps.spec.ts need to wait for a summary in order to fall into its test scenario. There was some missing configuration on them:
Besides those changes, I made some reorganization to these tests since added config is necessary only for tests that wait for a summary so I separated them into a different file and move some functions to a utils file well.
Some of these tests are currently failing in ODSP and so I'll head up OCE in case they keep failing after this PR is merged. If this approach work, I'll use it for refresh snapshot tests that are currently failing for what I suspect the same reason.