Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker files to use Debian bookworm #23543

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update docker files to use Debian bookworm #23543

wants to merge 3 commits into from
+3 −3

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Jan 14, 2025 •
edited
Loading

Description

Update docker files to use Debian bookworm since buster is years out of support and lacks python 3.8 needed by newer node-gyp.

  • Confirm this fixes pnpm 9 upgrade via Test updating docker base images and pnpm #23546 (I had to test this manually since CI got throttled, but the fix was confirmed)
  • Add this docker images to the CI machine image to avoid downloading it every run.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions github-actions bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Jan 14, 2025
@CraigMacomber
Copy link
Contributor Author

#23546 is being used to test/confirm this fixes the python version newer node-gyp requires in the pnpm update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CraigMacomber