Fix Windows 10 title bar borders #36429
Open
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingzing
commented
Dec 18, 2024
| @@ -82,6 +82,7 @@ double GetHeight(int maxCustomActionCount) => | |||
| }; | |||
|
|
|||
| WindowHelpers.BringToForeground(this.GetWindowHandle()); | |||
| WindowHelpers.ForceTopBorder1PixelInset(this.GetWindowHandle()); | |||
There was a problem hiding this comment.
The docs for DwmExtendFrameIntoClientArea() say that:
This function must be called whenever Desktop Window Manager (DWM) composition is toggled. Handle the WM_DWMCOMPOSITIONCHANGED message for composition change notification.
...however, the docs for WM_DWMCOMPOSITIONCHANGED go on to note that:
As of Windows 8, DWM composition is always enabled, so this message is not sent regardless of video mode changes.
...so I don't think we need to handle this in Window.Activated--just one call at creation time seems to be enough.
pingzing
commented
Dec 18, 2024
| @@ -241,6 +241,10 @@ private void OnLaunchedFromRunner(string[] cmdArgs) | |||
| // https://github.com/microsoft/microsoft-ui-xaml/issues/7595 - Activate doesn't bring window to the foreground | |||
| // Need to call SetForegroundWindow to actually gain focus. | |||
| WindowHelpers.BringToForeground(settingsWindow.GetWindowHandle()); | |||
|
|
|||
| // https://github.com/microsoft/microsoft-ui-xaml/issues/8948 - A window's top border incorrectly | |||
There was a problem hiding this comment.
Should this note be inline at call sites, or on the function itself?
crutkas
added
the
Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The top border of windows in Windows 10 will no longer always be black, instead of the appropriate color. Specifically, it fixes the following windows:
PR Checklist
Detailed Description of the Pull Request / Additional comments
This adds a bit of extra code to make any window that's using WinUI and
ExtendsContentIntoTitleBaralso callDwmExtendFrameIntoClientArea()on that window. This does nothing on Windows 11, but on Windows 10, resolves the "top 1px border is black" bug, with one caveat.That caveat is visible in my changes to the Peek module: I changed it from using
AppWindow.TitleBar.ExtendsContentIntoTitleBarto just using theExtendsContentIntoTitleBarproperty directly on theMUX.Window. This is because, for some reason, using theAppWindow.TitleBar's version of the property makesDwmExtendFrameIntoClientArea()suddenly do nothing. No clue why.This is not ideal, because it's my understanding that
AppWindow.TitleBaris The Future(tm), and the oldExtendsContentIntoTitleBaris probably going to be deprecated soon.Other thoughts:
ForceTopBorder1PixelInset()is kind of a stupid name. Open to suggestions.ForceTopBorder1PixelInset()so it's a no-op on W11?Validation Steps Performed
Opened each of:
...on Windows 10 and verified that the top borders all showed correctly.
I also validated (just for the Settings Window and HOSTS editor window) that the appearance on Windows 11 was unchanged.