Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AOT] clean up AOT issue in Settings.UI #36559

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[AOT] clean up AOT issue in Settings.UI #36559

wants to merge 1 commit into from
+201 −99

Conversation

moooyo
Copy link
Contributor

@moooyo moooyo commented Dec 25, 2024 •
edited
Loading

Summary of the Pull Request

  • Clean up AOT build issue.
  • Replace Assembly.GetExeAssembly.Location with AppContext.BaseDirectory in CmdNotFoundViewModel.cs
  • Add type to ResourceLoader in src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs
  • Move PowerToysReleaseInfo to Helpers folder
  • Add define for ActionMessage and use it to replace the anonymous type in src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
    Manual test passed. If we need any addtional test, please let me know.
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@moooyo moooyo requested a review from yeelam-gordon December 25, 2024 05:09
@moooyo moooyo added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 25, 2024
Sergio0694
Sergio0694 reviewed Dec 25, 2024
View reviewed changes
src/settings-ui/Settings.UI/Helpers/NativeKeyboardHelper.cs
@@ -18,7 +18,7 @@ internal struct INPUT

internal static int Size
{
get { return Marshal.SizeOf(typeof(INPUT)); }
get { return Marshal.SizeOf<INPUT>(); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is INPUT blittable? If so you should just do sizeof(INPUT). Same for all other Marshal.SizeOf uses in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio0694 Sergio0694 Sergio0694 left review comments

@yeelam-gordon yeelam-gordon Awaiting requested review from yeelam-gordon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
5. Needs Attention
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moooyo @Sergio0694