Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings > PT Run] Plugin manager: Add plugins version and website #36580

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Dec 26, 2024

Summary of the Pull Request

This PR implements a website link and the plugin version into the plugin metadata line visible in PT Run settings.

If the website uri in the plugin.json is badly formatted the link is not available in settings ui. This is to prevent a page crash.

image

Sample screenshot with third-party plugin
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Open tasks

  • Get plugin metadata from PT Run into Settings app
    • Get version from assembly file
    • Update ViewModels
    • Implement ViewModel bindings into XAML code
  • Improve the XAML code for the items separating dot. (Optional.)
  • Add template selector to switch between layout with and without website (In case the website uri is not well formed.)
  • Update plugin metadata in PowerToys repository to have the correct website in the json files.
  • Update screenshot.

Validation Steps Performed

Manual tested with default plugins and different website uri strings.

@htcfreek htcfreek self-assigned this Dec 26, 2024
@htcfreek htcfreek added Product-Settings The standalone PowerToys Settings application Area-User Interface things that regard UX for PowerToys Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Dec 26, 2024
@htcfreek
Copy link
Collaborator Author

@davidegiacometti
Currently I using the Product version and I saw some third-party plugins that have a strange formatted product version. Should we better use the file version instead? What do you think?

Example:
image

@crutkas
Copy link
Member

crutkas commented Dec 26, 2024

Nice!

@davidegiacometti
Copy link
Collaborator

@htcfreek nice work! 😃

Yeah, I think we should use file version since .NET 8 introduced a breaking change on how revision is handled in product version: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review December 28, 2024 13:44
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Needs-Review This Pull Request awaits the review of a maintainer. Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants