-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings > PT Run] Plugin manager: Add plugins version and website #36580
base: main
Are you sure you want to change the base?
Conversation
src/settings-ui/Settings.UI/SettingsXAML/Views/PowerLauncherPage.xaml
Outdated
Show resolved
Hide resolved
@davidegiacometti |
Nice! |
@htcfreek nice work! 😃 Yeah, I think we should use file version since .NET 8 introduced a breaking change on how revision is handled in product version: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link |
Summary of the Pull Request
This PR implements a website link and the plugin version into the plugin metadata line visible in PT Run settings.
If the website uri in the
plugin.json
is badly formatted the link is not available in settings ui. This is to prevent a page crash.Sample screenshot with third-party plugin
PR Checklist
Detailed Description of the Pull Request / Additional comments
Open tasks
Validation Steps Performed
Manual tested with default plugins and different website uri strings.