-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] feat(51556): support satisfies operator on functions/classes #57859
base: main
Are you sure you want to change the base?
Conversation
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
@a-tarasyuk Really appreciate for your effort for making satisfies works on functions! Is this PR still in draft status or close to ship? Plz consider adding it to typescript 5.6 🙏🏼 @DanielRosenwasser and @RyanCavanaugh |
@alvis It's still a draft because there's no final consensus on certain cases. In addition, I think that version 5.6 won't include this feature... I'm uncertain about the future of this feature, however, @RyanCavanaugh or @DanielRosenwasser might have more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to this functionality. I think the satisfies operator is already supported on functions, it's just not supported on function declarations.
Does this also bring support for @satisfies
in JSDoc? Could you add tests for it? See my comment here for an example that is expected to work.
Fixes #51556