Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port C28127 to CodeQL query #87

Merged
merged 11 commits into from
Oct 25, 2023
Merged

Port C28127 to CodeQL query #87

merged 11 commits into from
Oct 25, 2023

Conversation

jacob-ronstadt
Copy link
Contributor

Checklist for Pull Requests

  • Description is filled out.
  • Only one query or related query group is in this pull request.
  • The version number on changed queries has been increased via the @version comment in the file header.
  • All unit tests have been run: (Test README.md).
  • Commands codeql database create and codeql database analyze have completed successfully.
  • A .qhelp file has been added for any new queries or updated if changes have been made to an existing query.

@NateD-MSFT
Copy link
Contributor

  • Please retarget to "development" instead of main.
  • Have you run the query on our samples and internal Windows databases to get more coverage?

@jacob-ronstadt jacob-ronstadt changed the base branch from main to development October 24, 2023 19:19
NateD-MSFT
NateD-MSFT approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@NateD-MSFT NateD-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Go ahead and squash and merge.

@jacob-ronstadt jacob-ronstadt merged commit 1afd4c0 into development Oct 25, 2023
2 checks passed
@NateD-MSFT NateD-MSFT mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NateD-MSFT NateD-MSFT NateD-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-ronstadt @NateD-MSFT