Merge branch 'main' into main

microsoft · Sep 27, 2024 · 6f52523 · 6f52523
2 parents 7c6493a + 754c2d1
commit 6f52523
Show file tree

Hide file tree

Showing 102 changed files with 642 additions and 2,362 deletions.
diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml
@@ -13,6 +13,7 @@ jobs:
               with:
                   node-version: 16
             - run: npm ci
+            - run: npm run build
             - run: npm test
 
     publish-gpr:
@@ -28,6 +29,7 @@ jobs:
                   node-version: 16
                   registry-url: https://npm.pkg.github.com/
             - run: npm ci
+            - run: npm run build
             - run: npm publish
               env:
                   NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
-node_modules
+node_modules
+dist/
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1 +1,2 @@
+npm run build
 npm test
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -22,9 +22,10 @@ or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any addi
 
 -   Install [Visual Studio Code](https://code.visualstudio.com/).
 
--   Install [Node.js](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm).
+-   Install [Node.js](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm). Please use node version 16.
 
--   [Fork the repo and clone your fork](https://docs.github.com/en/get-started/quickstart/fork-a-repo)
+-   **Internal collaborators:** Please send Aubrey Quinn your email address. After getting `Write` access, you can create branches and directly submit pull requests against this repo.
+-   **External collaborators:** [Fork the repo and clone your fork](https://docs.github.com/en/get-started/quickstart/fork-a-repo)
 
 -   Install the dependencies
 

diff --git a/COVERAGE.md b/COVERAGE.md
@@ -7,7 +7,7 @@ We currently cover the following components:
     -   [x] AvatarGroup
     -   [] Badge
         -   [x] Badge
-        -   [] CounterBadge
+        -   [x] CounterBadge
         -   [N/A] PresenceBadge
     -   [x] Breadcrumb
     -   [x] Button
@@ -37,16 +37,16 @@ We currently cover the following components:
     -   [x] Input
     -   [x] Label
     -   [x] Link
-    -   [] Menu
-        -   [] Menu
-        -   [] MenuList
-    -   [] MessageBar
+    -   [x] Menu
+        -   [x] Menu
+        -   [x] MenuList
+    -   [x] MessageBar
     -   [N/A] Overflow
     -   [] Persona
     -   [] Popover
     -   [N/A] Portal
     -   [x] ProgressBar
-    -   [] Rating
+    -   [x] Rating
     -   [] RatingDisplay
     -   [x] Radio
     -   [x] RadioGroup
@@ -60,7 +60,7 @@ We currently cover the following components:
     -   [] SwatchPicker
     -   [x] Switch
     -   [] Table
-    -   [] TabList
+    -   [x] TabList
     -   [] Tag
         -   [] InteractionTag
         -   [] Tag

diff --git a/README.md b/README.md
@@ -174,6 +174,7 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [spin-button-unrecommended-labelling](docs/rules/spin-button-unrecommended-labelling.md)               | Accessibility: Unrecommended accessibility labelling - SpinButton                                                                                      | ✅  |    |    |
 | [spinner-needs-labelling](docs/rules/spinner-needs-labelling.md)                                       | Accessibility: Spinner must have either aria-label or label, aria-live and aria-busy attributes                                                        | ✅  |    |    |
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                         | Accessibility: Switch must have an accessible label                                                                                                    | ✅  |    |    |
+| [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                         | ✅  |    |    |
 | [toolbar-missing-aria](docs/rules/toolbar-missing-aria.md)                                             | Accessibility: Toolbars need accessible labelling: aria-label or aria-labelledby                                                                       | ✅  |    |    |
 | [tooltip-not-recommended](docs/rules/tooltip-not-recommended.md)                                       | Accessibility: Prefer text content or aria over a tooltip for these components MenuItem, SpinButton                                                    | ✅  |    |    |
 

diff --git a/dist/lib/applicableComponents/buttonBasedComponents.d.ts b/dist/lib/applicableComponents/buttonBasedComponents.d.ts
diff --git a/dist/lib/applicableComponents/buttonBasedComponents.js b/dist/lib/applicableComponents/buttonBasedComponents.js
diff --git a/dist/lib/applicableComponents/imageBasedComponents.d.ts b/dist/lib/applicableComponents/imageBasedComponents.d.ts
diff --git a/dist/lib/applicableComponents/imageBasedComponents.js b/dist/lib/applicableComponents/imageBasedComponents.js
diff --git a/dist/lib/applicableComponents/inputBasedComponents.d.ts b/dist/lib/applicableComponents/inputBasedComponents.d.ts
diff --git a/dist/lib/applicableComponents/inputBasedComponents.js b/dist/lib/applicableComponents/inputBasedComponents.js
diff --git a/dist/lib/applicableComponents/linkBasedComponents.d.ts b/dist/lib/applicableComponents/linkBasedComponents.d.ts
diff --git a/dist/lib/applicableComponents/linkBasedComponents.js b/dist/lib/applicableComponents/linkBasedComponents.js
diff --git a/dist/lib/index.d.ts b/dist/lib/index.d.ts
diff --git a/dist/lib/index.js b/dist/lib/index.js
@@ -34,6 +34,7 @@ const spinner_needs_labelling_1 = __importDefault(require("./rules/spinner-needs
 const badge_needs_accessible_name_1 = __importDefault(require("./rules/badge-needs-accessible-name"));
 const progressbar_needs_labelling_1 = __importDefault(require("./rules/progressbar-needs-labelling"));
 const field_needs_labelling_1 = __importDefault(require("./rules/field-needs-labelling"));
+const tablist_and_tabs_need_labelling = __importDefault(require("./rules/tablist-and-tabs-need-labelling"));
 //------------------------------------------------------------------------------
 // Requirements
 //------------------------------------------------------------------------------
@@ -70,7 +71,8 @@ module.exports = {
         "spinner-needs-labelling": spinner_needs_labelling_1.default,
         "badge-needs-accessible-name": badge_needs_accessible_name_1.default,
         "progressbar-needs-labelling": progressbar_needs_labelling_1.default,
-        "field-needs-labelling": field_needs_labelling_1.default
+        "field-needs-labelling": field_needs_labelling_1.default,
+        "tablist-and-tabs-need-labelling": tablist_and_tabs_need_labelling.default
     },
     configs: {
         recommended: {
@@ -101,7 +103,8 @@ module.exports = {
                 "@microsoft/fluentui-jsx-a11y/dialogsurface-needs-aria": "error",
                 "@microsoft/fluentui-jsx-a11y/spinner-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/progressbar-needs-labelling": "error",
-                "@microsoft/fluentui-jsx-a11y/field-needs-labelling": "error"
+                "@microsoft/fluentui-jsx-a11y/field-needs-labelling": "error",
+                "@microsoft/fluentui-jsx-a11y/tablist-and-tabs-need-labelling": "error"
             }
         }
     }

diff --git a/dist/lib/rules/accordion-header-needs-labelling.d.ts b/dist/lib/rules/accordion-header-needs-labelling.d.ts
diff --git a/dist/lib/rules/accordion-header-needs-labelling.js b/dist/lib/rules/accordion-header-needs-labelling.js
diff --git a/dist/lib/rules/accordion-item-needs-header-and-panel.d.ts b/dist/lib/rules/accordion-item-needs-header-and-panel.d.ts
diff --git a/dist/lib/rules/accordion-item-needs-header-and-panel.js b/dist/lib/rules/accordion-item-needs-header-and-panel.js
diff --git a/dist/lib/rules/avatar-needs-name.d.ts b/dist/lib/rules/avatar-needs-name.d.ts
diff --git a/dist/lib/rules/avatar-needs-name.js b/dist/lib/rules/avatar-needs-name.js
diff --git a/dist/lib/rules/avoid-using-aria-describedby-for-primary-labelling.d.ts b/dist/lib/rules/avoid-using-aria-describedby-for-primary-labelling.d.ts