-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid Fix issue when scrolling horizontally and Virtualize="true" #3107
Draft
vnbaaij
wants to merge
3
commits into
dev
Choose a base branch
from
users/vnbaaij/datagrid-issue
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use correct spacer for Virtualize - Remove unused style - Only render row-type if not default
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.8%
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue description in #3102
It has to do with the way we create the HTML for the DataGrid that leads to the JS part of Virtualize not being called if the grid is horizontally scrolled for a certain part.
We could just the wisdom of the crowd to solve this!
If you want to help, please checkout the
users/vnbaaij/datagrid-issue
branch, run the Fluent.Demo.Server project and navigate to the/issue-tester
page. Scrolling vertically while the horizontal scroll is at the left margin works as it should. Scrolling vertically while the horizontal scroll is at the right margin leads to a blank grid. If the horizontal scrollbar is moved to the left sufficiently, the data re-appears...