chore(codemods): fix issues related to ts 5.5 upgrade

microsoft · Dec 20, 2024 · 83e4110 · 83e4110
1 parent b7abd9a
commit 83e4110
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/packages/codemods/package.json b/packages/codemods/package.json
@@ -25,7 +25,8 @@
   "devDependencies": {
     "@fluentui/eslint-plugin": "*",
     "@fluentui/scripts-jest": "*",
-    "@fluentui/scripts-tasks": "*"
+    "@fluentui/scripts-tasks": "*",
+    "typescript": "5.3.3"
   },
   "dependencies": {
     "tslib": "^2.1.0",

diff --git a/packages/codemods/src/codeMods/mods/componentToCompat/componentToCompat.mod.ts b/packages/codemods/src/codeMods/mods/componentToCompat/componentToCompat.mod.ts
@@ -1,4 +1,10 @@
-import { runComponentToCompat, buildCompatHash, ComponentToCompat, RawCompat, getNamedExports } from './compatHelpers';
+import {
+  runComponentToCompat,
+  buildCompatHash,
+  getNamedExports,
+  type RawCompat,
+  type ComponentToCompat as ComponentToCompatType,
+} from './compatHelpers';
 import { ExportMapping } from './namedExports';
 import { CodeMod } from '../../types';
 import { SourceFile } from 'ts-morph';
@@ -12,7 +18,7 @@ function getPath(root: string, componentName: string) {
   return `${root}${componentName}`;
 }
 
-export function createComponentToCompat(comp: RawCompat): ComponentToCompat {
+export function createComponentToCompat(comp: RawCompat): ComponentToCompatType {
   return {
     oldPath: getPath(completePath, comp.componentName),
     newComponentPath: getPath(newPathStart, comp.componentName),

diff --git a/packages/codemods/src/modRunner/tests/mocks/MockMods/CodeMod.mock.ts b/packages/codemods/src/modRunner/tests/mocks/MockMods/CodeMod.mock.ts
@@ -1,6 +1,7 @@
-import { CodeMod, ModResult, NoOp } from '../../../../codeMods/types';
+import { CodeMod as CodeModType, ModResult, NoOp } from '../../../../codeMods/types';
 import { Err } from '../../../../helpers/result';
-const CodeMod: CodeMod<string> = {
+
+const CodeMod: CodeModType<string> = {
   run: () => {
     return Err<ModResult, NoOp>({ logs: [] });
   },

diff --git a/syncpack.config.js b/syncpack.config.js
@@ -26,6 +26,11 @@ const config = {
       dependencies: ['@fluentui/**'],
       isIgnored: true,
     },
+    {
+      packages: ['@fluentui/codemods'],
+      dependencies: ['typescript'],
+      isIgnored: true,
+    },
     {
       packages: ['@fluentui/fluentui-repo'],
       dependencies: [