Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xplat): Update canUseDOM to be aware of ReactNative #30872

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

behowell
Copy link
Contributor

ℹ️ Note: This is being merged into the xplat branch, not master

Previous Behavior

The canUseDOM utility incorrectly returns false when used with react-strict-dom.

New Behavior

Hardcode canUseDOM to return true when running on react native. There is no server-side-rendering to consider for react native.

@behowell behowell self-assigned this Mar 25, 2024
@behowell behowell requested review from a team as code owners March 25, 2024 23:08
@github-actions github-actions bot added this to the March Project Cycle Q1 2024 milestone Mar 25, 2024
Copy link

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@behowell behowell merged commit 9a63a21 into microsoft:xplat Mar 26, 2024
13 checks passed
@behowell behowell deleted the xplat-canusedom branch March 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants