fix(react-drawer): InlineDrawer example fixes
#33192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
…fluentui into drawer-example-fixes
smhigley
approved these changes
Nov 6, 2024
marcosmoura
approved these changes
Nov 7, 2024
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently, screenreaders do not announce any information when an
InlineDraweris opened.New Behavior
This PR fixes the
InlineDrawerexamples to useToggleButtonsinstead, so when theInlineDraweris opened, screenreaders will announce that the button that opens theInlineDraweris pressed.I also added a line in the guidance section that specifies that focus needs to be manually set to the
InlineDrawerif the behavior is desired by the user, and that we do not provide that functionality by default.Related Issue(s)