-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pickers with input attribute compatibility. #33243
Updated pickers with input attribute compatibility. #33243
Conversation
@gouttierre @msft-fluent-ui-bot @JustSlone @layershifter @khmakoto @micahgodbolt Can someone please help me merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this work! I did an initial pass and left comments on stuff I saw. Let me know if they make sense, and if you have any questions!
change/@fluentui-react-fd94592f-6c11-434f-a340-fce340db9a34.json
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx
Outdated
Show resolved
Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change that needs to be made, and one optional change. Otherwise this looks ready!
@khmakoto What are the next steps? |
@tpalacino I'll merge your PR once all checks have completed (I just approved the workflows so CI starts to run those checks). |
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
Previous Behavior
The Picker components that extend the
BasePicker
andBasePickerListBelow
are missing properties that most other FluentUI user input component support. The missing properties include label, required, errorMessage, and onGetErrorMessage.New Behavior
The pickers now support the following optional properties:
TextField
.TextField
.ComboBox
.TextField
.Related Issue(s)